- Industry
- Banking
- Department
- Engineering
- Team
- Application Engineering
- Kind
- Decision-maker
- Approver
- Head of Technology Operations
- Code
- ENG-04
It reviews pull requests to the bank's systems for bugs, security flaws, missing tests and breaches of the coding standards, with special attention to money arithmetic, payment idempotency, logging of customer data and authorisation checks. It comments on the exact lines and decides whether to approve, request changes or send for a second reviewer under the four-eyes rule.
How it works
7 steps, and a person signs off before step 7.
- 01Looks it up
Finds the record the request is about in the code repository: the pull request diff, its tests and the files it touches..
- 02Reads the request
Works out what is being asked and what a complete answer needs.
- 03Checks the facts
Checks figures, dates and rules against the source records, not from memory.
- 04Forecasts, when it decides
Projects what each option will cost or return before it recommends one.
- 05Works it through
Prepares the draft, match, recommendation or reply, with its sources.
- 06Asks a person
Hands the work to Head of Technology Operations with its reasoning before anything goes out.
- 07Acts
Once approved, it acts in the code repository: it posts the review comments and decision on the pull request. and records what was done.
What it works with
Your knowledge, your systems, your people.
Knows
The code review standard: secure coding for financial services, PCI DSS rules for card data, customer data secrecy in logs, money handling, the four-eyes rule for production changes, and sensitive paths.
Reads from
the code repository: the pull request diff, its tests and the files it touches.
Acts in
the code repository: it posts the review comments and decision on the pull request.
Hands back
An object with decision (approve, request_changes or second_reviewer), comments (a list with path, line, severity and comment), security_findings (a list), tests_ok (true or false) and summary.
Asks a person when
The change touches payments/, cards/, auth/, ledger/, interest/, migrations/, infra/, a finding is critical, or the agent would approve a change that has a finding at or above high.
Settings
Your limits, set by your managers.
| Setting | Default | What it controls |
|---|---|---|
| Block on severity | high | Findings at or above this block approval. |
| Largest reviewable change (lines) | 400 | Larger changes are sent back to be split. |
| Tests required | On | When on, changed logic needs tests. |
| Sensitive paths | payments/, cards/, auth/, ledger/, interest/, migrations/, infra/ | Changes here need a second human reviewer. |
| Most comments | 15 | The review stays focused. |
Limits are settings, not code: a manager changes them without a developer.
Rules it always follows
- Block on findings at or above high.
- Card numbers, CVVs, PINs, passwords and full account numbers are never logged; any such log line is a critical finding.
- Money uses decimal types and every payment path is idempotent.
- When on is true, changed logic without tests is not approved.
- A change touching payments/, cards/, auth/, ledger/, interest/, migrations/, infra/ always needs a second human reviewer under the four-eyes rule.
- Changes over 400 lines are sent back to be split.
See the Code Review Agent agent on your own work.
We’ll run it on a sample of your work and show you what your approver would see.