- Industry
- Hotel
- Department
- Engineering
- Team
- Application Engineering
- Kind
- Decision-maker
- Approver
- Head of Hotel Technology
- Code
- ENG-04
It reviews pull requests to the group's hotel software (the booking engine, reservation services, integrations with the property management system, point-of-sale and door-lock interfaces) for bugs, security flaws, card-data handling, missing tests and breaches of the coding standards, and comments on the exact lines. It decides whether to approve, request changes or block, and never merges.
How it works
7 steps, and a person signs off before step 7.
- 01Looks it up
Finds the record the request is about in the code repository: the pull request diff, its checks and the history of the files changed..
- 02Reads the request
Works out what is being asked and what a complete answer needs.
- 03Checks the facts
Checks figures, dates and rules against the source records, not from memory.
- 04Forecasts, when it decides
Projects what each option will cost or return before it recommends one.
- 05Works it through
Prepares the draft, match, recommendation or reply, with its sources.
- 06Asks a person
Hands the work to Head of Hotel Technology with its reasoning before anything goes out.
- 07Acts
Once approved, it acts in the code repository: it posts the review comments and the verdict on the pull request. and records what was done.
What it works with
Your knowledge, your systems, your people.
Knows
The coding standards and review checklist: the secure coding rules, PCI DSS rules for code that touches payments or card tokens, guest personal data handling, the rules for rate and tax calculations and the paths that need a second reviewer.
Reads from
the code repository: the pull request diff, its checks and the history of the files changed.
Acts in
the code repository: it posts the review comments and the verdict on the pull request.
Hands back
An object with verdict (approve, request_changes or block), findings (a list, each with file, line, severity, category and comment), needs_second_reviewer (true or false) and summary.
Asks a person when
It would approve a change under payments/, card-tokens/, guest-profile/, door-lock/, auth/, migrations/, approve a hotfix that skipped tests, or the change touches payments, card tokens or guest data.
Settings
Your limits, set by your managers.
| Setting | Default | What it controls |
|---|---|---|
| Block when a finding is at or above | high | A finding at or above this severity blocks the change. |
| Largest change it reviews in one go (lines) | 400 | A bigger change is sent back to be split. |
| Require tests for changed logic | On | When on, changed rate, tax, cancellation or payment logic without tests gets changes requested. |
| Paths that need a second reviewer | payments/, card-tokens/, guest-profile/, door-lock/, auth/, migrations/ | Comma-separated. A change here needs a second human reviewer whatever its verdict. |
| Most comments per review | 15 | Beyond this it groups minor points into one summary comment. |
Limits are settings, not code: a manager changes them without a developer.
Rules it always follows
- Block when any finding is at or above high; card numbers or security codes in logs, storage or responses are always critical.
- Send back any change above 400 lines to be split, unless it is a hotfix.
- When on is true, request changes on rate, tax, tourism fee, cancellation or payment logic without tests.
- A change under payments/, card-tokens/, guest-profile/, door-lock/, auth/, migrations/ needs a second human reviewer; say so in the verdict.
- Check that guest personal data is not logged in clear text and that new fields respect marketing consent and retention.
- Comment on exact lines, at most 15 comments, worst first; never merge.
See the Code Review Agent agent on your own work.
We’ll run it on a sample of your work and show you what your approver would see.