- Industry
- Oil & Gas
- Department
- Engineering
- Team
- Application Engineering
- Kind
- Decision-maker
- Approver
- Tech Lead
- Code
- ENG-04
It reviews pull requests on the operational and commercial applications for bugs, security flaws, missing tests and breaches of the coding standards, with extra scrutiny on paths that compute allocated volumes, regulatory figures, permit states or anything bridging into the OT network. It comments on exact lines and decides approve, request changes or block, and never merges.
How it works
7 steps, and a person signs off before step 7.
- 01Looks it up
Finds the record the request is about in the code repository: the pull request, its diff and history..
- 02Reads the request
Works out what is being asked and what a complete answer needs.
- 03Checks the facts
Checks figures, dates and rules against the source records, not from memory.
- 04Forecasts, when it decides
Projects what each option will cost or return before it recommends one.
- 05Works it through
Prepares the draft, match, recommendation or reply, with its sources.
- 06Asks a person
Hands the work to Tech Lead with its reasoning before anything goes out.
- 07Acts
Once approved, it acts in the code repository: it posts the review comments and verdict on the pull request. and records what was done.
What it works with
Your knowledge, your systems, your people.
Knows
The coding standards, the secure coding guide, the IT/OT boundary rules (IEC 62443 zones and conduits) and the list of sensitive paths.
Reads from
the code repository: the pull request, its diff and history.
Acts in
the code repository: it posts the review comments and verdict on the pull request.
Hands back
An object with verdict (approve, request changes or block), comments (with file, line, severity and text) and summary.
Asks a person when
The verdict is block, or the change touches allocation/, measurement/, permits/, ot_gateway/, auth/, payments/ or crosses the IT/OT boundary.
Settings
Your limits, set by your managers.
| Setting | Default | What it controls |
|---|---|---|
| Block on severity | high | Findings at this level block. |
| Largest reviewable change (lines) | 400 | Bigger changes are asked to be split. |
| Require tests | On | Changed logic needs tests. |
| Sensitive paths | allocation/, measurement/, permits/, ot_gateway/, auth/, payments/ | Comma-separated. |
| Most comments | 15 | The most important first. |
Limits are settings, not code: a manager changes them without a developer.
Rules it always follows
- Block on findings at high or above.
- Ask for changes above 400 lines to be split.
- Require tests when on is on.
- Block any change that opens a write path into the OT network or bypasses the OT gateway, and send every change in allocation/, measurement/, permits/, ot_gateway/, auth/, payments/ to the Tech Lead.
- Leave at most 15 comments and never merge.
See the Code Review Agent agent on your own work.
We’ll run it on a sample of your work and show you what your approver would see.