- Industry
- Retail
- Department
- Engineering
- Team
- Application Engineering
- Kind
- Decision-maker
- Approver
- Engineering Manager
- Code
- ENG-04
It reviews code changes to the storefront, commerce services, store systems and integrations for bugs, standards and risk, and decides approve, request changes or block. It looks hardest at money handling, stock reservation, shopper data and anything in PCI DSS scope.
How it works
7 steps, and a person signs off before step 7.
- 01Looks it up
Finds the record the request is about in the code repository: the pull request diff, the files around it, its tests and the CI results..
- 02Reads the request
Works out what is being asked and what a complete answer needs.
- 03Checks the facts
Checks figures, dates and rules against the source records, not from memory.
- 04Forecasts, when it decides
Projects what each option will cost or return before it recommends one.
- 05Works it through
Prepares the draft, match, recommendation or reply, with its sources.
- 06Asks a person
Hands the work to Engineering Manager with its reasoning before anything goes out.
- 07Acts
Once approved, it acts in the code repository: it posts the review comments and the decision on the pull request. and records what was done.
What it works with
Your knowledge, your systems, your people.
Knows
The engineering standards: coding standards per language, the review checklist, the PCI DSS scope and data protection rules, the money and stock handling patterns, and the peak trading change policy.
Reads from
the code repository: the pull request diff, the files around it, its tests and the CI results.
Acts in
the code repository: it posts the review comments and the decision on the pull request.
Hands back
An object with decision (approve, request_changes or block), comments (a list of file, line, severity and comment), risk_summary and second_reviewer_needed (true or false).
Asks a person when
The change touches payments/, checkout/payment-callback/, till/payment/, pricing or refund logic, or is larger than 600 lines.
Settings
Your limits, set by your managers.
| Setting | Default | What it controls |
|---|---|---|
| Largest change it reviews alone (lines) | 600 | A larger change needs a second human reviewer. |
| Block changes without tests | On | When on, a change to logic without tests is blocked. |
| Paths in PCI DSS scope | payments/, checkout/payment-callback/, till/payment/ | Comma-separated. Changes here always need the approver. |
Limits are settings, not code: a manager changes them without a developer.
Rules it always follows
- Block any change that logs or stores card data, weakens authentication or exposes shopper data.
- A change to payments/, checkout/payment-callback/, till/payment/ always needs the Engineering Manager.
- When on is true, block logic changes without tests.
- Check money uses minor units and the agreed rounding, and stock is reserved and released correctly.
- A change larger than 600 lines needs a second human reviewer.
- Each comment gives the file, line, problem and fix.
See the Code Review Agent agent on your own work.
We’ll run it on a sample of your work and show you what your approver would see.